Marking an entry as done completely always crashes the app

comfortableglove · February 13, 2020, 9:06am

What I did:
Pick any entry from On The Agenda or other project, hit “Mark as done completely”

What happened:
App crashes (though marked as done when I restart)

What I expected:
Entry is getting marked as done and removed from the agenda

Things that might be helpful to know (Agenda version, OS and model, etc):

Agenda 9.1.3 MAS (used non-MAS but same issues)
macOS Catalina 10.15.3
Tried wiping agenda and all its settings before reinstalling but the issue came back

Crash report:

Process:               Agenda [6244]
Path:                  /Applications/Agenda.app/Contents/MacOS/Agenda
Identifier:            com.momenta.agenda.macos
Version:               9.1.3 (111)
App Item ID:           1287445660
App External ID:       834561496
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Agenda [6244]
User ID:               503

Date/Time:             2020-02-13 15:57:54.054 +0900
OS Version:            Mac OS X 10.15.3 (19D76)
Report Version:        12
Bridge OS Version:     4.2 (17P3050)
Anonymous UUID:        E77D5B97-9D90-43CC-9BD8-1CD97E443515

Sleep/Wake UUID:       D3E74512-78B0-4D06-B09A-0FCCC98EF505

Time Awake Since Boot: 13000 seconds
Time Since Wake:       11000 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_INSTRUCTION (SIGILL)
Exception Codes:       0x0000000000000001, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Illegal instruction: 4
Termination Reason:    Namespace SIGNAL, Code 0x4
Terminating Process:   exc handler [6244]

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.momenta.agendafoundation  	0x000000010350ef0e 0x10345c000 + 732942
1   com.momenta.agendafoundation  	0x000000010346c270 0x10345c000 + 66160
2   com.momenta.agenda.macos      	0x00000001027c74db 0x1025dd000 + 2008283
3   com.momenta.agenda.macos      	0x00000001027c75d8 0x1025dd000 + 2008536
4   com.apple.AppKit              	0x00007fff342df9e3 -[NSViewController _sendViewWillDisappear] + 22
5   com.apple.AppKit              	0x00007fff34146e5b -[NSView _recursiveViewWillDisappearBecauseHidden] + 84
6   com.apple.AppKit              	0x00007fff340c367c -[NSView(NSInternal) _setHidden:setNeedsDisplay:] + 369
7   com.apple.AppKit              	0x00007fff342d4beb -[NSCollectionViewItem _setHiddenForReuse:] + 188
8   com.apple.UIFoundation        	0x00007fff67b10309 _reuseViewWithReuseQueue + 134
9   com.apple.UIFoundation        	0x00007fff67b10133 -[_NSCollectionViewCore _reuseCell:notifyDidEndDisplaying:] + 250
10  com.apple.UIFoundation        	0x00007fff67bc1667 -[_NSCollectionViewCore _updateAnimationDidStop:finished:context:] + 1694
11  com.apple.UIFoundation        	0x00007fff67bc0fb8 __76-[_NSCollectionViewCore _updateWithItems:tentativelyForReordering:animator:]_block_invoke.1089 + 77
12  libdispatch.dylib             	0x00007fff6e387583 _dispatch_call_block_and_release + 12
13  libdispatch.dylib             	0x00007fff6e38850e _dispatch_client_callout + 8
14  libdispatch.dylib             	0x00007fff6e393bc4 _dispatch_main_queue_callback_4CF + 1105
15  com.apple.CoreFoundation      	0x00007fff36f15e00 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
16  com.apple.CoreFoundation      	0x00007fff36ed5b8a __CFRunLoopRun + 2370
17  com.apple.CoreFoundation      	0x00007fff36ed4bd3 CFRunLoopRunSpecific + 499
18  com.apple.HIToolbox           	0x00007fff35a2a65d RunCurrentEventLoopInMode + 292
19  com.apple.HIToolbox           	0x00007fff35a2a39d ReceiveNextEventCommon + 600
20  com.apple.HIToolbox           	0x00007fff35a2a127 _BlockUntilNextEventMatchingListInModeWithFilter + 64
21  com.apple.AppKit              	0x00007fff3409aba4 _DPSNextEvent + 990
22  com.apple.AppKit              	0x00007fff34099380 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352
23  com.apple.AppKit              	0x00007fff3408b09e -[NSApplication run] + 658
24  com.apple.AppKit              	0x00007fff3405d465 NSApplicationMain + 777
25  com.momenta.agenda.macos      	0x00000001025e2259 0x1025dd000 + 21081
26  libdyld.dylib                 	0x00007fff6e3e17fd start + 1

Thread 1:
0   libsystem_kernel.dylib        	0x00007fff6e52225a mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x00007fff6e5225d0 mach_msg + 60
2   com.momenta.agenda.macos      	0x0000000102a591dd 0x1025dd000 + 4702685
3   libsystem_pthread.dylib       	0x00007fff6e5e5e65 _pthread_start + 148
4   libsystem_pthread.dylib       	0x00007fff6e5e183b thread_start + 15

Thread 2:: com.apple.NSEventThread
0   libsystem_kernel.dylib        	0x00007fff6e52225a mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x00007fff6e5225d0 mach_msg + 60
2   com.apple.CoreFoundation      	0x00007fff36ed6d0b __CFRunLoopServiceMachPort + 322
3   com.apple.CoreFoundation      	0x00007fff36ed58e7 __CFRunLoopRun + 1695
4   com.apple.CoreFoundation      	0x00007fff36ed4bd3 CFRunLoopRunSpecific + 499
5   com.apple.AppKit              	0x00007fff3423d792 _NSEventThread + 132
6   libsystem_pthread.dylib       	0x00007fff6e5e5e65 _pthread_start + 148
7   libsystem_pthread.dylib       	0x00007fff6e5e183b thread_start + 15

Thread 3:: com.apple.NSURLConnectionLoader
0   libsystem_kernel.dylib        	0x00007fff6e52225a mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x00007fff6e5225d0 mach_msg + 60
2   com.apple.CoreFoundation      	0x00007fff36ed6d0b __CFRunLoopServiceMachPort + 322
3   com.apple.CoreFoundation      	0x00007fff36ed58e7 __CFRunLoopRun + 1695
4   com.apple.CoreFoundation      	0x00007fff36ed4bd3 CFRunLoopRunSpecific + 499
5   com.apple.CFNetwork           	0x00007fff35639012 0x7fff355ef000 + 303122
6   com.apple.Foundation          	0x00007fff395707a8 __NSThread__start__ + 1064
7   libsystem_pthread.dylib       	0x00007fff6e5e5e65 _pthread_start + 148
8   libsystem_pthread.dylib       	0x00007fff6e5e183b thread_start + 15

Thread 4:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 5:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 6:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 7:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 8:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 9:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 10:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 11:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 12:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 13:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 14:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 15:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 16:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 17:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 18:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 19:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 20:
0   libsystem_pthread.dylib       	0x00007fff6e5e1818 start_wqthread + 0

Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x0000000000000000  rbx: 0x0000000000000069  rcx: 0x000000010350e221  rdx: 0x0000000000000000
  rdi: 0x0000000000000064  rsi: 0x00007ffeed620bc8  rbp: 0x00007ffeed620d70  rsp: 0x00007ffeed620bb0
   r8: 0x00000000000000ff   r9: 0x00000000000007fb  r10: 0x0000000000000a40  r11: 0x0000000000000040
  r12: 0x00007ffeed620bb0  r13: 0x00006000010c7020  r14: 0x00007fff8b5c3578  r15: 0x0000600003468060
  rip: 0x000000010350ef0e  rfl: 0x0000000000010297  cr2: 0x000000011d721000
  
Logical CPU:     2
Error Code:      0x00000000
Trap Number:     6

mekentosj · February 13, 2020, 9:10am

Thanks for reporting, we’ll have a look

comfortableglove · February 14, 2020, 8:59am

So I started marking things done and removing from the agenda on my phone instead of mac to get around this, but the app still sometimes crashes on my mac after the changes are synced.

I think it might be something in the removing elements from the view logic?

If I can provide any other info on my setup please let me know!

comfortableglove · March 9, 2020, 6:30am

Is there anything I can provide to debug this? I use Agenda quite often (and paid for it) but marking anything as done completely + removing from the agenda crashing the app is a big downer and costs time

mekentosj · March 9, 2020, 9:30am

That’s very odd, are you saying it also crashes the mac app if you mark it as done on your iPhone? I do notice you use version 9.1.3, please make sure you use version 9.2.1, does that perhaps already solve the problem?

comfortableglove · March 12, 2020, 3:24am

Yes, the app crashes also sometimes on my Mac when I mark it as done on my iPhone

I just tried it again after checking that I am on 9.2.1 and the 3rd item that I marked as done crashed the app.

I sent a crash report just now

mekentosj · March 12, 2020, 10:12am

Thanks, we’ll have a look.

drewmccormack · March 12, 2020, 10:32am

I am trying to reproduce this problem, but I can’t seem to get it to crash. I have Mac and iOS versions running with the same data, and I have On the Agenda selected. I then mark notes on the iPhone as done. This does not remove them from the Agenda — they stay on the Agenda.

Am I doing what you are doing? If not, can you explain in more detail what leads to this crash? Do you notice anything about what you have to do? Eg does it only happen when you have the cursor in the note you are marking done? Does it only happen when the note is/is not on the screen on the Mac? Or do you have to have the cursor in the Mac app too? Any tip that can help me make it happen.

Note we also have a new beta version. It is possible that the problem was fixed. Please check when the new 9.3 version comes out to see if it still happens.

comfortableglove · March 13, 2020, 9:20am

I just tried the 9.3 beta and the problem still happens

I am really not doing anything special, I just use the keybinding alt+cmd+enter from within a note to mark it as done and remove it from the Agenda in the same step.

I debugged this a bit with the scenarios you mentioned and noticed:

It doesn’t crash when I click on a note and use alt+cmd+enter
It doesn’t crash when I click into a empty note and use alt+cmd+enter
It crashes every single time when I go into a empty note, type a few characters, then use alt+cmd+enter
It crashes every single time when I put the cursor into a note that has text in it, then hit alt+cmd+enter
It doesn’t crash when I click on a note that has text in it (cursor not inside the note) and use alt+cmd+enter

Reinstalling and wiping all settings, then letting it sync from iCloud doesn’t fix the issue

I DMd you a short screencast

comfortableglove · March 13, 2020, 9:28am

I spoke too early and didn’t properly restart after letting it update to 9.3.

I just tested everything again under the 9.3 beta and the crashes stopped so I think this is fixed

drewmccormack · March 13, 2020, 9:49am

Ah, right. Yes, I am pretty certain we had that key combo “mark as done” reported by someone else, and fixed it. 9.3 should have it fixed.